Fix codegen randomness for chip-tool-darwin. #18276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
holbrookt,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
kpschoedel,
lazarkov,
LuDuda,
mlepage-google,
mrjerryjohns and
msandstedt
pullapprove
bot
requested review from
tecimovic,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
andy31415
approved these changes
May 10, 2022
|
PR #18276: Size comparison from 837b939 to 89a4b61 Full report (13 builds for cyw30739, k32w, linux, mbed, nrfconnect, p6, telink)
|
We had a race as to who initialized ChipClusters first: the test generation code (which used includeAll=true) or the command-generation code (which did not). Since the first init decides the behavior things were random. The fix is to consistently use includeAll=true in all of the bits in chip-tool and chip-tool-darwin, since that's the desired behavior anyway.
bzbarsky-apple
force-pushed
the
fix-chip-tool-darwin-codegen
branch
from
89a4b61 to
a5e6c7d
Compare
msandstedt
approved these changes
May 10, 2022
|
PR #18276: Size comparison from 837b939 to a5e6c7d Full report (20 builds for cc13x2_26x2, cyw30739, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
krypton36
approved these changes
May 10, 2022
This was referenced May 21, 2022
TE9 TC-LC-1.1 chip tool Darwin testing: Support needed for feature map, event list attributes
#18235
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a race as to who initialized ChipClusters first: the test
generation code (which used includeAll=true) or the command-generation
code (which did not). Since the first init decides the behavior
things were random.
The fix is to consistently use includeAll=true in all of the bits in
chip-tool and chip-tool-darwin, since that's the desired behavior
anyway.
Problem
See above.
Change overview
See above.
Testing
Ran codegen several times and it was stable. CI will tell for sure.